Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove sway wording #589

Merged
merged 3 commits into from
Sep 25, 2022
Merged

refactor: remove sway wording #589

merged 3 commits into from
Sep 25, 2022

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Sep 22, 2022 •
edited
Loading

closes:#257

  • AFAIK the rust SDK does not depend on any Sway functionality.
  • I have tried to remove all the Sway mentions from the code and left the documentation intact. I need the teams opinion on the wording I used :)

@hal3e hal3e requested a review from a team September 22, 2022 07:41
@hal3e hal3e self-assigned this Sep 22, 2022
MujkicA
MujkicA previously approved these changes Sep 22, 2022
View reviewed changes
packages/fuels-core/src/abi_encoder.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/abi_decoder.rs Outdated Show resolved Hide resolved
Salka1988
Salka1988 previously approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You've got them all.

segfault-magnet
segfault-magnet reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@segfault-magnet segfault-magnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soo, I have a good feeling the following is overkill, but just want to get it out there --

What do you think about a CI step which does a search of our docs and .rs files for sway wording?

Or we will be careful to not introduce it back :D

packages/fuels-core/src/abi_decoder.rs Outdated Show resolved Hide resolved
@hal3e
Copy link
Contributor Author

hal3e commented Sep 22, 2022

Soo, I have a good feeling the following is overkill, but just want to get it out there --

What do you think about a CI step which does a search of our docs and .rs files for sway wording?

Or we will be careful to not introduce it back :D

That is definitely an overkill :)

digorithm
digorithm requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Just some tiny nits.

packages/fuels-core/src/abi_decoder.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/code_gen.rs Outdated Show resolved Hide resolved
tools/fuels-abi-cli/src/main.rs Outdated Show resolved Hide resolved
iqdecay
iqdecay previously approved these changes Sep 25, 2022
View reviewed changes
@hal3e hal3e dismissed stale reviews from iqdecay, Salka1988, and MujkicA via 51bb871 September 25, 2022 17:28
@hal3e hal3e merged commit 01f924b into master Sep 25, 2022
@hal3e hal3e deleted the hal3e/remove-sway-wording branch September 25, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet left review comments

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay iqdecay approved these changes

@Salka1988 Salka1988 Salka1988 left review comments

@MujkicA MujkicA MujkicA left review comments

Assignees

@hal3e hal3e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hal3e @digorithm @Salka1988 @MujkicA @iqdecay @segfault-magnet