-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create an append_message_output
method
#590
Conversation
@mohammadfawaz I'm not sure I understood the context for this so I didn't include Sway tests as I would usually do, do you have some Sway code to show me where this API could interact? |
@iqdecay 2 points: 2.) we should consider if there's any other way to approach testing, as we've already seen that there's a circular dep issue between the stdlib (the tests use the SDK) and the SDK (which has some tests which use sway (and the stdlib). Open to ideas here, but the above approach would (imo) be better than the alternative, which is temporarily disabling tests and related functionality in the SDK during this process of re-syncing dependencies. |
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I left a nit and a question..
packages/fuels/tests/test_projects/append_message_output/Forc.toml
Outdated
Show resolved
Hide resolved
packages/fuels/tests/test_projects/append_message_output/src/main.sw
Outdated
Show resolved
Hide resolved
…toml Co-authored-by: Halil Beglerović <hal3e.git@gmail.com>
Closes #579 by creating an
append_message_output
method that works similarilyto
append_variable_output
.