Fix transfer to contract #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digorithm
approved these changes
Sep 28, 2022
| Opcode::TR(0x10, 0x11, 0x12), | ||
| Opcode::LW(0x12, 0x11, 0), | ||
| Opcode::ADDI(0x13, 0x11, WORD_SIZE as u16), | ||
| Opcode::TR(0x10, 0x12, 0x13), |
There was a problem hiding this comment.
how come we didn't catch in the tests? Because we used the base asset in the tests?
There was a problem hiding this comment.
@MujkicA mentioned in the PR title. Not because of the fact we're using the base asset, but because of what we were checking; we were checking the base asset ID only, which doesn't tell us much about the transfer itself.
There was a problem hiding this comment.
Yup, the previous test was just weak. My bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that our transfer-to-contract script is calculating the offset of the asset id incorrectly.
The corresponding test was passing because it was checking for the base asset id which is all 0s.
This PR corrects the script, and adapts the test to use a random asset id.