test: add unit tests for ABI function generation #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digorithm
reviewed
Jan 31, 2022
|
|
||
| // Regarding string->TokenStream->string, refer to `custom_types_gen` tests for more details. | ||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
I'm a bit confused, aren't these tests already being introduced in #73?
There was a problem hiding this comment.
Hah, it happens. You can close this one and we continue the review process on #73?
There was a problem hiding this comment.
Or maybe, since you wanna merge this one first, you can address my comments on #73 here, then ping me when you want me to take another pass?
There was a problem hiding this comment.
I'm going to fix everything at once in #73.
|
Closing in favor of #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements unit tests for the function expansion portion of the ABIgen.
It closes issue #6.