Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-tagged version of forc in CI #699

Merged
merged 14 commits into from
Nov 17, 2022
Merged

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented Nov 15, 2022

added flags FORC_PATCH_BRANCH and FORC_PATCH_REVISION in CI
flag FORC_PATCH_BRANCH allows CI to use the forc version found on the given branch
flag FORC_PATCH_REVISION allows CI to use a forc version that is behind an existing rev. number

@Salka1988 Salka1988 marked this pull request as draft November 15, 2022 15:16
@Salka1988 Salka1988 self-assigned this Nov 15, 2022
@Salka1988 Salka1988 linked an issue Nov 15, 2022 that may be closed by this pull request
@Salka1988 Salka1988 marked this pull request as ready for review November 16, 2022 00:51
@Salka1988 Salka1988 requested a review from a team November 16, 2022 15:01
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the code and think it looks godd! I'm just not sure how we would use it in reality. Can you provide more explanation?

@Salka1988
Copy link
Member Author

Salka1988 commented Nov 16, 2022

I understand the code and think it looks godd! I'm just not sure how we would use it in reality. Can you provide more explanation?

If I understood correctly, we need the option to use the forc version that has not yet been released and is located somewhere on a branch or under a revision number. If the assumption is correct, then we will do it like this:

FORC_PATCH_BRANCH = "Salka1988/new_unreleased_forc_on_some_branch"

This will install version from the branch and use it in CI. Same with revision number.

@Salka1988 Salka1988 requested a review from a team November 17, 2022 16:22
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I've never needed to use an unreleased force version in the CI, but if that's a real need, then adding the option to support this doesn't hurt.

@Salka1988 Salka1988 dismissed iqdecay’s stale review November 17, 2022 16:45

Did not demand changes, but an explanation

@Salka1988 Salka1988 merged commit b8efb1f into master Nov 17, 2022
@Salka1988 Salka1988 deleted the Salka1988/forc_ci_patch branch November 17, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: find a way to use non-tagged version of forc in CI
3 participants