-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix setup_test_client
parameters
#737
Conversation
…inConfig and ConsensusParameters
pub async fn setup_test_client(
coins: Vec<Coin>,
messages: Vec<Message>,
node_config: Option<Config>,
chain_config: Option<ChainConfig>,
consensus_parameters_config: Option<ConsensusParameters>,
) regarding the second part of this PR, I can suggest that we create a builder pattern struct and put all the parameters we need in it. 🤷♂️ or we could exclude let chain_config = ChainConfig {
transaction_parameters: ConsensusParameters::default(),
..ChainConfig::local_testnet()
}; |
That makes sense to me @Salka1988. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #730
Now when using
setup_test_client
by passing bothChainConfig
andConsensusParameters
, the provided parameters won't be ignored