Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reintroduce Abigen publicly in a new crate fuels-code-gen #819

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

segfault-magnet
Copy link
Contributor

Moving Abigen from fuels-core into fuels-macro and making it private broke the indexer which relied on Abigen due to issues of using abigen! inside other macros.

Abigen could not have been exported from fuels-macro since it is a proc-macro crate type that cannot export anything except proc macros.

The only solution was to create a new crate.

@segfault-magnet segfault-magnet added the enhancement New feature or request label Feb 3, 2023
@segfault-magnet segfault-magnet requested a review from a team February 3, 2023 21:23
@segfault-magnet segfault-magnet self-assigned this Feb 3, 2023
digorithm
digorithm previously approved these changes Feb 3, 2023
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet; :shipit:!

@segfault-magnet segfault-magnet enabled auto-merge (squash) February 3, 2023 21:47
@segfault-magnet segfault-magnet merged commit c003e35 into master Feb 3, 2023
@segfault-magnet segfault-magnet deleted the segfault_magnet/make_abigen_public branch February 3, 2023 21:47
MujkicA pushed a commit that referenced this pull request Feb 10, 2023
…819)

Abigen moved into a new crate named `fuels-code-gen` so that the indexer team might use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants