-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable cargo sparse protocol #888
enable cargo sparse protocol #888
Conversation
Turns out dtolnay/rust-toolchain does this already by checking if the rust version is compatible. So the CI will use the sparse protocol automatically because we've bumped the rust version to 1.68.0. So, CI-wise, the @FuelLabs/sdk-rust thoughts? |
I would not add it. SDK users can set it up locally if they want and it will become a default anyway at some point. |
SDK devs *, this doesn't impact users. I wouldn't add it as well but figured I better ask. We still need to bump the rust version for it to work in CI though |
The CI toolchain setup already detects whether the chosen compiler is compatible. Only thing that is needed is to bump the rustc version.
Removed the config. Left only the version bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Please do not forget to update the commit message
When have I ever :D |
closes: #886
This should speed up our CI.
Checklist