Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cargo sparse protocol #888

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

segfault-magnet
Copy link
Contributor

closes: #886
This should speed up our CI.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@segfault-magnet segfault-magnet added the tech-debt Improves code quality or safety label Mar 15, 2023
@segfault-magnet segfault-magnet requested a review from a team March 15, 2023 07:20
@segfault-magnet segfault-magnet self-assigned this Mar 15, 2023
@segfault-magnet
Copy link
Contributor Author

Turns out dtolnay/rust-toolchain does this already by checking if the rust version is compatible. So the CI will use the sparse protocol automatically because we've bumped the rust version to 1.68.0.

So, CI-wise, the .cargo/config.toml is not needed. But I'm thinking about whether to remove it because it will apply to anyone building the project locally. But then again we all can just set this config in our $HOME/.cargo/config.toml.

@FuelLabs/sdk-rust thoughts?

@hal3e
Copy link
Contributor

hal3e commented Mar 15, 2023

I would not add it. SDK users can set it up locally if they want and it will become a default anyway at some point.

@segfault-magnet
Copy link
Contributor Author

SDK users can set it up locally if they want

SDK devs *, this doesn't impact users.

I wouldn't add it as well but figured I better ask.

We still need to bump the rust version for it to work in CI though

The CI toolchain setup already detects whether the chosen compiler is
compatible. Only thing that is needed is to bump the rustc version.
@segfault-magnet
Copy link
Contributor Author

Removed the config. Left only the version bump.

Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please do not forget to update the commit message

@segfault-magnet
Copy link
Contributor Author

segfault-magnet commented Mar 15, 2023

Please do not forget to update the commit message

When have I ever :D

@segfault-magnet segfault-magnet merged commit 4cbe86c into master Mar 15, 2023
@segfault-magnet segfault-magnet deleted the segfault_magnet/sparse_protocol_enable branch March 15, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Improves code quality or safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cargo sparse protocol to speed up the CI
2 participants