Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add clippy check without all features #900

Merged
merged 3 commits into from
Mar 23, 2023
Merged

ci: add clippy check without all features #900

merged 3 commits into from
Mar 23, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Mar 22, 2023 •
edited

Some clippy warnings were not reported by the CI because we did not have a check without all features.

Checklist

  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the ci GitHub CI build/pipeline label Mar 22, 2023
@hal3e hal3e self-assigned this Mar 22, 2023
@hal3e hal3e requested a review from a team March 22, 2023 09:40
@hal3e hal3e marked this pull request as ready for review March 22, 2023 09:56
segfault-magnet
segfault-magnet approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@segfault-magnet segfault-magnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOice

@hal3e hal3e requested a review from a team March 22, 2023 22:05
iqdecay
iqdecay approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hal3e hal3e merged commit ca327ed into master Mar 23, 2023
@hal3e hal3e deleted the hal3e/ci-clippy branch March 23, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqdecay iqdecay iqdecay approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@hal3e hal3e

Labels
ci GitHub CI build/pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hal3e @iqdecay @segfault-magnet