Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-export more fuel-tx types #969

Merged
merged 5 commits into from
Jun 1, 2023
Merged

chore: re-export more fuel-tx types #969

merged 5 commits into from
Jun 1, 2023

Conversation

ra0x3
Copy link

@ra0x3 ra0x3 commented May 16, 2023

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Description

  • Re-exporting more of fuel-tx so that we don't have to use fuel-tx directly.
  • This will obviously break when upgrading to fuel-tx 0.31 but cross that bridge when we get to it?

@ra0x3 ra0x3 requested a review from digorithm as a code owner May 16, 2023 21:25
@ra0x3 ra0x3 self-assigned this May 16, 2023
@ra0x3 ra0x3 requested a review from iqdecay as a code owner May 16, 2023 21:25
hal3e
hal3e requested changes May 17, 2023
View reviewed changes
packages/fuels/src/lib.rs Outdated Show resolved Hide resolved
iqdecay
iqdecay suggested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it needs to be aliased.

packages/fuels/src/lib.rs Outdated Show resolved Hide resolved
@digorithm digorithm requested review from iqdecay and hal3e May 23, 2023 18:54
iqdecay
iqdecay approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I didn't approve earlier

@hal3e hal3e changed the title chore: re-export more fuel-tx chore: re-export more fuel-tx types Jun 1, 2023
hal3e
hal3e approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hal3e hal3e merged commit 87d5fce into master Jun 1, 2023
31 checks passed
@hal3e hal3e deleted the rashad/reexport-more-fuel-tx branch June 1, 2023 10:08
iqdecay pushed a commit that referenced this pull request Jun 2, 2023
@ra0x3 @digorithm
@Salka1988 @hal3e @iqdecay
chore: re-export more fuel-tx types (#969)
cf8c6d9 
Co-authored-by: Rashad Alston <rashad@Rashads-Air.lan>
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
Co-authored-by: Emir <emirsalkicart@gmail.com>
Co-authored-by: Halil Beglerović <git@hal3e.io>
MujkicA pushed a commit that referenced this pull request Jun 5, 2023
@ra0x3 @digorithm
@Salka1988 @hal3e @MujkicA
chore: re-export more fuel-tx types (#969)
2d884cb 
Co-authored-by: Rashad Alston <rashad@Rashads-Air.lan>
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
Co-authored-by: Emir <emirsalkicart@gmail.com>
Co-authored-by: Halil Beglerović <git@hal3e.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@iqdecay iqdecay iqdecay approved these changes

@hal3e hal3e hal3e approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

Assignees

@ra0x3 ra0x3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ra0x3 @Br1ght0ne @Salka1988 @iqdecay @hal3e @segfault-magnet @digorithm