Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: path of WalletUnlocked in fuels::accounts #987

Merged
merged 10 commits into from
Jun 1, 2023

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented May 31, 2023

This PR modifies the path for the WalletUnlocked functionality in the fuels::accounts. The previous path, fuels::accounts::WalletUnlocked, has been disabled, and only the new path, fuels::accounts::wallet::WalletUnlocked, is now enabled.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Salka1988 Salka1988 added the bug Something isn't working label May 31, 2023
@Salka1988 Salka1988 self-assigned this May 31, 2023
@Salka1988 Salka1988 linked an issue May 31, 2023 that may be closed by this pull request
Br1ght0ne
Br1ght0ne previously approved these changes May 31, 2023
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also thanks for bumping the forc version in CI!

iqdecay
iqdecay previously approved these changes May 31, 2023
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and suggested something but you can ignore since we are not really consistent regarding this in the codebase.

packages/fuels-test-helpers/src/accounts.rs Outdated Show resolved Hide resolved
Co-authored-by: iqdecay <victor@berasconsulting.com>
@Salka1988 Salka1988 dismissed stale reviews from iqdecay and Br1ght0ne via e5e12f3 May 31, 2023 14:06
iqdecay
iqdecay previously approved these changes May 31, 2023
Br1ght0ne
Br1ght0ne previously approved these changes May 31, 2023
@Salka1988 Salka1988 enabled auto-merge (squash) May 31, 2023 14:18
# Conflicts:
#	packages/fuels-programs/src/call_utils.rs
#	packages/fuels-test-helpers/src/accounts.rs
#	packages/fuels/tests/contracts.rs
#	packages/fuels/tests/predicates.rs
#	packages/fuels/tests/providers.rs
#	packages/fuels/tests/types_predicates.rs
#	packages/fuels/tests/wallets.rs
@Salka1988 Salka1988 dismissed stale reviews from Br1ght0ne and iqdecay via fa8b8e5 May 31, 2023 14:35
@hal3e hal3e changed the title Refactor path for WalletUnlocked in fuels::accounts refactor: path of WalletUnlocked in fuels::accounts Jun 1, 2023
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salka1988 Salka1988 merged commit 69a2b9b into master Jun 1, 2023
31 checks passed
@Salka1988 Salka1988 deleted the Salka1988/wallet_unlocked branch June 1, 2023 09:01
iqdecay added a commit that referenced this pull request Jun 2, 2023
This PR modifies the path for the `WalletUnlocked` functionality in the
`fuels::accounts`. The previous path, `fuels::accounts::WalletUnlocked`,
has been disabled, and only the new path,
`fuels::accounts::wallet::WalletUnlocked`, is now enabled.

Co-authored-by: iqdecay <victor@berasconsulting.com>
MujkicA pushed a commit that referenced this pull request Jun 5, 2023
This PR modifies the path for the `WalletUnlocked` functionality in the
`fuels::accounts`. The previous path, `fuels::accounts::WalletUnlocked`,
has been disabled, and only the new path,
`fuels::accounts::wallet::WalletUnlocked`, is now enabled.

Co-authored-by: iqdecay <victor@berasconsulting.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ambiguity when importing WalletUnlocked
5 participants