Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump fuel-abi-types to v0.3.0 #990

Merged
merged 7 commits into from
Jun 13, 2023
Merged

deps: bump fuel-abi-types to v0.3.0 #990

merged 7 commits into from
Jun 13, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented May 31, 2023

close #986.

Relevant PR:

Waiting for:

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added the tech-debt Improves code quality or safety label May 31, 2023
@kayagokalp kayagokalp self-assigned this May 31, 2023
kayagokalp added a commit to FuelLabs/fuel-abi-types that referenced this pull request Jun 5, 2023
@kayagokalp kayagokalp enabled auto-merge (squash) June 8, 2023 10:15
@kayagokalp kayagokalp marked this pull request as draft June 8, 2023 12:51
auto-merge was automatically disabled June 8, 2023 12:51

Pull request was converted to draft

Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't removed the program_binding/abi_types file.

@kayagokalp kayagokalp requested a review from iqdecay June 8, 2023 13:25
@kayagokalp kayagokalp marked this pull request as ready for review June 8, 2023 13:25
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kayagokalp kayagokalp enabled auto-merge (squash) June 9, 2023 13:46
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kayagokalp kayagokalp merged commit c2c371c into master Jun 13, 2023
31 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/986 branch June 13, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Improves code quality or safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider exposing FullProgramABI either by making it public or taking it out to fuel-abi-types
4 participants