Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use #[allow(dead_code)] in forc projects #991

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jun 6, 2023

#[allow(dead_code)] was recently added to sway so I have updated our test projects to lower the number of warnings we get when building them.

I have also removed some other warnings like unused variables etc.

@hal3e hal3e self-assigned this Jun 6, 2023
@hal3e hal3e requested a review from a team June 6, 2023 12:41
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hal3e hal3e enabled auto-merge (squash) June 8, 2023 07:43
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MujkicA MujkicA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hal3e hal3e merged commit 09ebbef into master Jun 9, 2023
31 checks passed
@hal3e hal3e deleted the hal3e/remove-forc-warn branch June 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants