Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow wallet creation without a provider #1444

Closed
mpoplavkov opened this issue Nov 21, 2023 · 2 comments · Fixed by #1566
Closed

Allow wallet creation without a provider #1444

mpoplavkov opened this issue Nov 21, 2023 · 2 comments · Fixed by #1566
Assignees
@petertonysmith94
Labels
feat Issue is a feature
Milestone
1 - Salamander

Comments

@mpoplavkov
Copy link

mpoplavkov commented Nov 21, 2023 •
edited by arboleya

This PR (#1181) introduced a breaking change: all wallet creation methods now require a provider instance.

For me it looks like that provider should not be necessary for such methods, cause a wallet is just a key pair, to create one, you don't need any chain parameters.

Author of the PR refers to the Rust SDK, but in Rust SDK provider is optional.

This issue is a suggestion to make the provider parameter optional again. Are the any pitfalls which do not allow to do this?

Note
@arboleya arboleya added the feat Issue is a feature label Dec 7, 2023
This was referenced Dec 19, 2023
Closed
Closed
@petertonysmith94
Copy link
Contributor

@danielbate could you assign me to this please?

@arboleya arboleya mentioned this issue Dec 19, 2023
Merged
@arboleya arboleya added this to the 1 - Salamander milestone Jan 8, 2024
@arboleya
Copy link
Member

Completed via #1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertonysmith94 petertonysmith94

Labels
feat Issue is a feature
Projects
None yet
Milestone
1 - Salamander
Development

Successfully merging a pull request may close this issue.

feat: create a wallet without a provider petertonysmith94/fuels-ts
3 participants
@arboleya @petertonysmith94 @mpoplavkov