Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine similar methods in BaseInvocationScope #1865

Open
Torres-ssf opened this issue Mar 12, 2024 · 1 comment
Open

Combine similar methods in BaseInvocationScope #1865

Torres-ssf opened this issue Mar 12, 2024 · 1 comment
Labels
chore Issue is a chore feat Issue is a feature p0 High priority

Comments

@Torres-ssf
Copy link
Contributor

Torres-ssf commented Mar 12, 2024

We currently have multiple dry-run methods within BaseInvocationScope: simulate, dryRun, and get.

We need to validate which methods we are maintaining and which ones we are going to remove.

This is some brainstorm originally posted here:

/*
  Call - accepts optional flags
*/
call({ ..., dryRun: boolean, skipUtxoValidation: boolean })
// - Requires Wallet
// - Never use fake UTXOs

// valid calls
call({ ... }) // = default
call({ ..., dryRun: true }) // current simulate
call({ ..., dryRun: true, skipUtxoValidation: true }) // current dryRun

// invalid calls
call({ ..., skipUtxoValidation: true }) // throws error (requires dryRun=true)
call({ ..., dryRun: false, skipUtxoValidation: true }) // throws error (requires dryRun=true)
/*
  Get - requires no special flags
*/
get({ ... })
// - Do not require but can receive a Wallet
// - Always use fake UTXOs (accounts for lack of balance)
@Torres-ssf Torres-ssf added chore Issue is a chore mainnet labels Mar 12, 2024
@arboleya arboleya changed the title Review multiple dry-run methods within BaseInvocationScope Combine similar methods in BaseInvocationScope Mar 13, 2024
@arboleya
Copy link
Member

This could potentially be done together with:

@maschad maschad removed the mainnet label Apr 8, 2024
@arboleya arboleya added the p1 Medium priority label Jun 9, 2024
@arboleya arboleya added this to the 1.0 caterpillar milestone Jun 12, 2024
@arboleya arboleya added feat Issue is a feature and removed p1 Medium priority labels Jun 12, 2024
@arboleya arboleya added the p0 High priority label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore feat Issue is a feature p0 High priority
Projects
None yet
Development

No branches or pull requests

3 participants