Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement get method on BaseInvocationScope #1860

Merged
merged 37 commits into from
Mar 14, 2024
Merged

feat: implement get method on BaseInvocationScope #1860

merged 37 commits into from
Mar 14, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf added feat Issue is a feature mainnet labels Mar 12, 2024
@Torres-ssf Torres-ssf self-assigned this Mar 12, 2024
danielbate
danielbate reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Sergio, couple comments / questions

packages/fuel-gauge/src/contract.test.ts Outdated Show resolved Hide resolved
apps/docs/src/guide/contracts/read-only-calls.md Outdated Show resolved Hide resolved
packages/program/src/functions/base-invocation-scope.ts Show resolved Hide resolved
@Torres-ssf Torres-ssf mentioned this pull request Mar 12, 2024
Open
danielbate
danielbate previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

petertonysmith94
petertonysmith94 reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits - otherwise 👌🏼

apps/docs/src/guide/contracts/interacting-with-contracts.md Show resolved Hide resolved
apps/docs/src/guide/contracts/interacting-with-contracts.md Outdated Show resolved Hide resolved
apps/docs/src/guide/contracts/interacting-with-contracts.md Outdated Show resolved Hide resolved
apps/docs/src/guide/contracts/interacting-with-contracts.md Outdated Show resolved Hide resolved
@Torres-ssf @petertonysmith94
Update apps/docs/src/guide/contracts/interacting-with-contracts.md
c14fdad 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
@Torres-ssf Torres-ssf marked this pull request as ready for review March 13, 2024 13:19
Torres-ssf and others added 2 commits March 13, 2024 10:44
@Torres-ssf @petertonysmith94
Update apps/docs/src/guide/contracts/interacting-with-contracts.md
e6662df 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
@Torres-ssf @petertonysmith94
Update apps/docs/src/guide/contracts/interacting-with-contracts.md
e5f2b15 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Torres-ssf and others added 3 commits March 13, 2024 11:14
@Torres-ssf @arboleya
Update apps/docs/src/guide/contracts/interacting-with-contracts.md
49503c4 
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@Torres-ssf @arboleya
Update apps/docs/src/guide/contracts/interacting-with-contracts.md
5ade6b0 
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@Torres-ssf
fix flag name
e0493f0
arboleya
arboleya previously approved these changes Mar 13, 2024
View reviewed changes
apps/docs/src/guide/contracts/interacting-with-contracts.md Outdated Show resolved Hide resolved
@Torres-ssf Torres-ssf enabled auto-merge (squash) March 13, 2024 15:32
nedsalk
nedsalk approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.5%(+0.01%) 70.35%(+0%) 77.98%(-0.05%) 79.59%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 86.07%
(+0.18%)		 67.56%
(+0%)		 83.33%
(+0%)		 86.58%
(+0.17%)

@Torres-ssf Torres-ssf merged commit b8c3401 into master Mar 14, 2024
13 checks passed
@Torres-ssf Torres-ssf deleted the st/feat/implement-get-method branch March 14, 2024 05:28
@fuel-service-user fuel-service-user mentioned this pull request Mar 14, 2024
Merged
@Torres-ssf Torres-ssf mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce way to read data from the chain
5 participants
@Torres-ssf @arboleya @danielbate @petertonysmith94 @nedsalk