Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predicateData Bytes To Predicate Resources And Inputs #2379

Closed
Torres-ssf opened this issue May 23, 2024 · 0 comments · Fixed by #2380
Closed

Add predicateData Bytes To Predicate Resources And Inputs #2379

Torres-ssf opened this issue May 23, 2024 · 0 comments · Fixed by #2380
Assignees
Labels
bug Issue is a bug

Comments

@Torres-ssf
Copy link
Contributor

Now that we have dropped V0 encoding logic, we can safely add the predicateData to the predicate resources and inputs since there is no need to handle the bytes padding within predicate arguments to handle the dynamic size of the array of policies.

We still need to have the populateTransactionPredicateData in place because there are some scenarios where predicate-fetched resources will not include the predicate and predicateData.

I believe this mostly happens within wallet connectors, where the connector Account is instantiated using the predicate address, and the predicate is instantiated only before submitting the TX.

@Torres-ssf Torres-ssf added the bug Issue is a bug label May 23, 2024
@Torres-ssf Torres-ssf self-assigned this May 23, 2024
@nedsalk nedsalk changed the title Add predicateData Bytes To Predicate Respources And Inputs Add predicateData Bytes To Predicate Resoources And Inputs May 24, 2024
@nedsalk nedsalk changed the title Add predicateData Bytes To Predicate Resoources And Inputs Add predicateData Bytes To Predicate Resources And Inputs May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant