Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v0 encoding logic #2109

Closed
danielbate opened this issue Apr 18, 2024 · 2 comments · Fixed by #2238
Closed

Remove v0 encoding logic #2109

danielbate opened this issue Apr 18, 2024 · 2 comments · Fixed by #2238
Assignees
Labels
chore Issue is a chore

Comments

@danielbate
Copy link
Contributor

danielbate commented Apr 18, 2024

Once #2050 has been merged and sway encoding improvements to v1 have been completed, we should remove all v0 specific logic:

  • Encoding should now fallback to v1, strategy can remain in place for future custom encoding
  • Remove redundant v0 coders, some redistribution may be required for anything still being used by transactions
  • Remove v0 function selector encoding and contract call script
  • Remove heap pointer logic
  • Remove heap type validation for multicalls
  • Remove experimental tests
  • Ensure documentation type support is up to date
@danielbate danielbate added blocked chore Issue is a chore labels Apr 18, 2024
@danielbate danielbate self-assigned this Apr 18, 2024
@arboleya
Copy link
Member

@danielbate I think we can start this right after #2050, regardless of FuelLabs/sway#5727.

Only v1 will be accepted anyway, and the stabilization should be transparent.

@danielbate
Copy link
Contributor Author

Agreed 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants