Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @fuel-ts packages references inside fuels-ts #286

Closed
luizstacio opened this issue May 19, 2022 · 2 comments · Fixed by #437
Closed

Improve @fuel-ts packages references inside fuels-ts #286

luizstacio opened this issue May 19, 2022 · 2 comments · Fixed by #437
Assignees
Labels
feat Issue is a feature

Comments

@luizstacio
Copy link
Member

When clicking on from "@fuel-ts/<package>". The link opens the node_modules folder. But it should open the package folder.

PR #238 used the typescript directly, which was good, but pnpm link was broken.
PR #246 fixed the issue with pnpm link, but the correct track of the package was lost opening the node_modules.

We should have both

  • Good linking
  • pnpm link working
@luizstacio luizstacio added the feat Issue is a feature label May 19, 2022
@AlicanC
Copy link
Contributor

AlicanC commented May 22, 2022

This is another issue I was having since #238. Both linking and clicking refs worked fine before.

I'm actually going to write a script that switches this repo from PNPM+tsup to Yarn+tsc so I can have all the functionality lost with #238 back.

@AlicanC
Copy link
Contributor

AlicanC commented Jun 18, 2022

I think we can revert #246. The issue was not being able to link to a Yarn project, but since SwaySwap is also PNPM now maybe that's not an issue?

I'm trying this locally now and it seems fine: #345

(Didn't try linking with SwaySwap though, and I might be breaking other stuff so not sure.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants