fix: change build tasks in order to use pnpm link correctly #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This enables us to use |
luizstacio
approved these changes
May 5, 2022
pedronauck
added a commit
that referenced
this pull request
May 6, 2022
* fix: mjs dist path on package.json * chore: use dist files as main target on package.json * chore: add new instruction for build, watch and link
AlicanC
added a commit
that referenced
this pull request
May 7, 2022
pedronauck
added a commit
that referenced
this pull request
May 7, 2022
* fix: mjs dist path on package.json * chore: use dist files as main target on package.json * chore: add new instruction for build, watch and link
AlicanC
added a commit
that referenced
this pull request
May 7, 2022
AlicanC
added a commit
that referenced
this pull request
Jun 18, 2022
AlicanC
added a commit
that referenced
this pull request
Jun 20, 2022
AlicanC
added a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request intends to change our environment in order to be able to use
pnpm linkcorrectly.After talking with @luizstacio we tried to keep the direct import in all
package.jsonby using thepublishConfig, but we notice that if you link some package to the global pnpm store, it'll keep the samepackage.jsonthat uses themainfield pointing to the Typescript file. This is bad if you trying to use the linked package with some bundler (vite, react-scripts, etc) because the bundler won't handle loaders to bundle outside the package directory, and by consumingindex.tsfile this is needed.So, we change to instead of consuming direct inside our monorepo, we need to build/watch and have all
package.jsonfield pointing to the same publish config. It's an annoying trade-off, but by now is the only way to work.I'll open an issue on PNPM repository in order to check if is possible to run this scenário.
Main Changes
This is specified in our README as well.