Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: standardize error handling across all packages #1230

Merged
merged 104 commits into from
Sep 14, 2023
Merged

refactor: standardize error handling across all packages #1230

merged 104 commits into from
Sep 14, 2023

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Sep 1, 2023 •
edited

@Torres-ssf
add errors package to contract package
7468979
@Torres-ssf
add errors package to crypto package
4c7460c
@Torres-ssf
add errors package to predicate package
18ca051
@Torres-ssf
add some error codes
0a165ca
@Torres-ssf
using FuelError in crypto package
dc58ac8
@Torres-ssf
using FuelError in predicate package
cf9cc07
@Torres-ssf
using FuelError in contract package
f33fdf8
@Torres-ssf
add invalid transaction input error code
0db73f2
@Torres-ssf
add more error codes
ac2b47d
@Torres-ssf
add invalid transaction output error code
536f7c5
@Torres-ssf
add more error codes
e53ad80
@Torres-ssf
use error code invalid ttl
a91874c
@Torres-ssf
use error code gas price too low and invalid
0d771e8
@Torres-ssf
use error code invalid transaction input
5c852d6
@Torres-ssf
use error code invalid transaction output
7ff6b27
@Torres-ssf
use error code transaction not found
ef81429
@Torres-ssf
use error code invalid transaction type
d496766
@Torres-ssf
use error code invalid transaction status
3589773
@Torres-ssf
use error code invalid receipt type
516cbfd
@Torres-ssf
update more errros to FuelErrors
0bb732a
@Torres-ssf
using errors package to script package
645078a
@Torres-ssf
using fuel errors on script package
2906c8a
@Torres-ssf
using fuel errors on mnemonic package
d99c770
@Torres-ssf
add error codes related to mnemonic package
b895bdd
@Torres-ssf
using FuelError on mnemonic package
6bf7e18
@Torres-ssf
using erros package on wallet manager package
eb2a2db
@Torres-ssf
adding more error codes
789c2b2
@Torres-ssf
using FuelError instead of Error
a4aa6e8
@Torres-ssf
using errors package on hdwallet package
d816848
@Torres-ssf
add error code for hdwallet
0d57c7a
arboleya
arboleya previously approved these changes Sep 13, 2023
View reviewed changes
@arboleya arboleya self-requested a review September 13, 2023 19:19
arboleya
arboleya previously approved these changes Sep 13, 2023
View reviewed changes
@arboleya arboleya self-requested a review September 13, 2023 19:31
arboleya
arboleya previously approved these changes Sep 13, 2023
View reviewed changes
arboleya
arboleya previously approved these changes Sep 13, 2023
View reviewed changes
camsjams
camsjams previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

danielbate
danielbate previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@Torres-ssf Torres-ssf merged commit 5310e8b into master Sep 14, 2023
8 checks passed
@Torres-ssf Torres-ssf deleted the st/refactor/using-fuel-error-on-sdk branch September 14, 2023 11:47
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@camsjams camsjams Awaiting requested review from camsjams

Assignees

@Torres-ssf Torres-ssf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibly new Flaky test Standardize error handling across all packages
5 participants
@Torres-ssf @arboleya @nedsalk @camsjams @danielbate