fix: reduce updateScriptRequest invocations and init asm for contract instructions
#1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsjams
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate and
nedsalk
as code owners
camsjams
commented
Sep 6, 2023
Coverage report
Show files with reduced coverage 🔻
Test suite run success1201 tests passing in 207 suites. Report generated by 🧪jest coverage report action from f267aeb |
added 3 commits
September 5, 2023 23:50
camsjams
commented
Sep 6, 2023
camsjams
changed the title
updateScriptRequest invocations and init asm for contract instructions
camsjams
changed the title
updateScriptRequest invocations and init asm for contract instructionsupdateScriptRequest invocations and init asm for contract instructions
added 2 commits
September 7, 2023 23:14
danielbate
approved these changes
Sep 8, 2023
Dhaiwat10
approved these changes
Sep 8, 2023
|
Having at least one test that reliably fails without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1227
By reducing the amount of calls to
updateScriptRequest, we can add an await for the ASM library before its used inside the creation of the contract call script