-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ensuring engine compatibility #1338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success1270 tests passing in 223 suites. Report generated by 🧪jest coverage report action from 128d7f7 |
This PR is published in NPM with version 0.0.0-pr-1338-20231012125323 |
arboleya
requested review from
digorithm,
camsjams,
Torres-ssf,
Dhaiwat10,
danielbate and
nedsalk
as code owners
October 12, 2023 13:11
Torres-ssf
approved these changes
Oct 12, 2023
camsjams
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚒
danielbate
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at reducing problems with (node) engine version mismatch.
engines
andpackageManager
field for all packages (package.json
).npmrc
)eslint-plugin-jsdoc
for newer engine supportThis should give users warnings when trying to install
fuels
while using unsupported engines.And disallow running
pnpm install
inside the monorepo: