Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Typegen support for StdString, RawSlice and Bytes #1412

Merged
merged 6 commits into from Nov 7, 2023
Merged

feat: improve Typegen support for StdString, RawSlice and Bytes #1412

merged 6 commits into from Nov 7, 2023

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Nov 7, 2023 •
edited

Closes #1413

@danielbate danielbate self-assigned this Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
85.96% (+0.01% 🔼)
 5731/6667
🟡 Branches 69.17% 846/1223
🟡 Functions 75.71% 932/1231
🟢 Lines
85.98% (+0.01% 🔼)
 5475/6368

Test suite run success

1368 tests passing in 248 suites.

Report generated by 🧪jest coverage report action from 2b809ad

@danielbate danielbate marked this pull request as ready for review November 7, 2023 18:58
camsjams
camsjams approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch

@danielbate danielbate merged commit 119f83c into master Nov 7, 2023
9 checks passed
@danielbate danielbate deleted the db/feat/improve-typegen-support-for-stdstring-byte-rawslice branch November 7, 2023 22:47
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@camsjams camsjams camsjams approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@danielbate danielbate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Typegen support for StdString, RawSlice and Bytes
3 participants
@danielbate @arboleya @camsjams