Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure hex values are prefixed or fail #1454

Merged
merged 14 commits into from
Nov 27, 2023
Merged

fix: ensure hex values are prefixed or fail #1454

merged 14 commits into from
Nov 27, 2023

Conversation

camsjams
Copy link
Contributor

@camsjams camsjams commented Nov 25, 2023

Closes #1148

Storage slot json files do not prefix hex values:

[
  {
    "key": "f383b0ce51358be57daa3b725fe44acdb2d880604e367199080b4379c41bb6ed",
    "value": "0000000000000000000000000000000000000000000000000000000000000000"
  }
]

There is an issue worth pursuing separately, but I think its fine as is since storage-slots are presumed to be generated by forc and can therefore be trusted as a hex value.

Copy link
Contributor

github-actions bot commented Nov 25, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
86.42% (+0.02% 🔼)
5798/6709
🟡 Branches
70.14% (+0.03% 🔼)
862/1229
🟡 Functions 77.15% 959/1243
🟢 Lines
86.39% (+0.02% 🔼)
5550/6424
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / utils.ts
90.2% (-0.19% 🔻)
85.71% (+1.5% 🔼)
92.31%
89.13% (-0.23% 🔻)

Test suite run success

1394 tests passing in 249 suites.

Report generated by 🧪jest coverage report action from 71970d9

Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a testcase for the reduced coverage on utils.ts would be nice to have, but I will leave up to you 👍🏻

@camsjams camsjams enabled auto-merge (squash) November 27, 2023 16:33
@camsjams camsjams merged commit c9a8b33 into master Nov 27, 2023
8 checks passed
@camsjams camsjams deleted the cm/issue-1148 branch November 27, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that expected hex data is always prefixed
3 participants