Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make startFuelCore package manager agnostic #1477

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Dhaiwat10
Copy link
Member

This PR fixes a bug where the initial approach used by startFuelCore to locate the fuels-core binaries was only working for pnpm. This is now package manger agnostic with this PR.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
86.41% (-0% 🔻)
5833/6750
🟡 Branches 69.92% 867/1240
🟡 Functions 77.06% 961/1247
🟢 Lines
86.38% (-0% 🔻)
5583/6463

Test suite run success

1402 tests passing in 251 suites.

Report generated by 🧪jest coverage report action from 2ecf1a4

@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) December 5, 2023 13:02
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Dhaiwat10 Dhaiwat10 merged commit f6d348f into master Dec 5, 2023
9 checks passed
@Dhaiwat10 Dhaiwat10 deleted the fix/fuels-core-package-agnostic branch December 5, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants