Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add unpublish workflow #1487

Merged
merged 4 commits into from
Dec 8, 2023
Merged

ci: add unpublish workflow #1487

merged 4 commits into from
Dec 8, 2023

Conversation

danielbate
Copy link
Contributor

Closes #1486

@danielbate danielbate self-assigned this Dec 7, 2023
@danielbate danielbate marked this pull request as ready for review December 7, 2023 19:04
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 86.54% 6025/6962
🟡 Branches 70.05% 933/1332
🟡 Functions 77.44% 992/1281
🟢 Lines 86.54% 5772/6670

Test suite run success

1465 tests passing in 258 suites.

Report generated by 🧪jest coverage report action from 546230b

@danielbate danielbate merged commit 03010f8 into master Dec 8, 2023
9 checks passed
@danielbate danielbate deleted the db/feat/add-unpublish-ci branch December 8, 2023 00:05
danielbate added a commit that referenced this pull request Dec 10, 2023
@@ -10,6 +10,7 @@
},
"packageManager": "pnpm@8.9.0",
"scripts": {
"dan": "tsx ./scripts/release-unpublish.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol

@@ -49,6 +50,7 @@
"@changesets/get-github-info": "^0.5.2",
"@fuel-ts/forc": "workspace:*",
"@fuel-ts/fuel-core": "workspace:*",
"@fuel-ts/versions": "workspace:^",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added for a reason or can I remove @danielbate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here, however, can't see it in master, going to remove 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I wonder why the second took place. 🤔

const { version: CURRENT_VERSION } = require('../packages/fuels/package.json');

vs

const { FUELS: CURRENT_VERSION } = versions;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpublish old versions workflow
4 participants