Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the hyperlinks to reference the new documentation hub #1520

Conversation

petertonysmith94
Copy link
Contributor

Currently, within the SDK, there are hyperlinks that reference the old documentation (https://fuellabs.github.io). For consistency and to ensure up to date information, we should be referencing the new documentation where possible (https://docs.fuel.network/)

Closes #1519

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2023

CLA assistant check
All committers have signed the CLA.

@danielbate danielbate added the docs Requests pertinent to documentation label Dec 14, 2023
@petertonysmith94
Copy link
Contributor Author

petertonysmith94 commented Dec 14, 2023

Haven't updated the following links

// Not sure where this should reference
https://fuelbook.fuel.network/master/index.html

// Not yet available
https://fuellabs.github.io/fuels-ts/guide/cli/config-file

// Doesn't exist in new docs...
https://fuellabs.github.io/sway/master/reference/documentation/operations/asset/transfer/address.html

// Can't find a reference to `fuelbook.fuel.network`
https://fuellabs.github.io/block-explorer-v2

@arboleya arboleya added this to the Beetle milestone Dec 14, 2023
@arboleya arboleya changed the base branch from master to rc/salamander December 14, 2023 14:48
@arboleya arboleya changed the base branch from rc/salamander to master December 14, 2023 14:49
@arboleya arboleya modified the milestones: 2 - Beetle, 1 - Salamander Dec 15, 2023
@arboleya arboleya changed the base branch from master to rc/salamander December 15, 2023 15:16
arboleya
arboleya previously approved these changes Dec 15, 2023
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 🤝

Now that I have changed the base branch, there is a minor conflict to fix.

@petertonysmith94
Copy link
Contributor Author

Thanks for your contribution. 🤝

Now that I have changed the base branch, there is a minor conflict to fix.

Hey Arboleya 👋🏼

Thanks for that - that should be sorted now, let me know if you need anything else from me 😄

@arboleya arboleya self-requested a review December 16, 2023 10:34
@Dhaiwat10 Dhaiwat10 merged commit 55e8301 into FuelLabs:rc/salamander Dec 18, 2023
9 checks passed
@arboleya arboleya mentioned this pull request Jan 26, 2024
44 tasks
arboleya added a commit that referenced this pull request Jan 26, 2024
* chore: updating code owners (#1496)
* docs: purge hardcoded snippets on 'using typegen' page (#1403)
* chore: remove method that's same as base method (#1445)
* chore: implement RC workflow (#1497)
* Revert "feat: add `Predicate.getTransferTxId` helper (#1467)"
* chore: fix rc release string replace (#1529)
* docs: Update some hyperlinks to reference the new documentation hub (#1520)
* chore: improve rc release message (#1559)
* feat: GraphQL subscriptions (#1374)
* chore: pin `graphql-request` to `v5` (#1567)
* chore: upgrade `tsx` (#1574)
* feat: migrate from Jest to Vitest (#1310)
* chore: fix temp test workflow (#1579)
* chore: update required node engine in `create-fuels` (#1582)
* chore: add node version test matrix (#1575)
* chore: fix broken rc message (#1580)
* chore: update nodejs to v20 (#1544)
* feat: accepting addresses as `string` (#1583)
* chore: properly format the PR coverage report comment (#1586)
* fix: flaky test (#1590)
* docs: update `deposit-and-withdraw` page (#1591)
* feat: retry mechanism (#1474)
* feat: replaced `semver` dependency with custom implementation (#1594)
* feat: replace `elliptic` with `@noble/curves` (#1601)
* chore: fix CI failing due to missing tag in test (#1614)
* feat: improve ABI Coders `decode` validation (#1426)
* fix: do not generate a coverage diff without coverage artifact (#1629)
* chore: pinpoint vitest to 1.0.4 (#1637)
* chore: remove `ethers` dependency from `utils` (#1640)
* fix: `getOperation` for `Transfer Asset` (#1619)
* fix: remove external font dependencies (#1642)
* fix: generate RC PR comment on `pull_request` event only (#1648)
* fix: fix failing `rc` comment (#1657)
* chore: add missing test group (#1658)
* feat: implement browser compatibility testing (#1630)
* chore: fix string replace in `rc` ci (#1659)
* chore: adding extra reporters (#1661)
* chore: manually trigger `rc` CI (#1660)
* feat: use `submitAndAwait` graphql endpoint (#1615)
* fix: flaky retry test (#1654)
* feat: create a wallet without a provider (#1566)
* chore!: Share single chainConfig and review node-related utilities (#1602)
* chore: use new temporary coverage artifact (#1676)
* fix: internalizing `findBinPath` utility (#1679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect hyperlinks for internal docs
5 participants