New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: subscriptions not closing after done #1793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
February 23, 2024 09:26
danielbate
reviewed
Feb 26, 2024
arboleya
reviewed
Feb 26, 2024
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
arboleya
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new direction. 🫡
Torres-ssf
approved these changes
Feb 26, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was part of #1597 which didn't get merged. In essence, the piping done in
was ignoring the value
{value: undefined, done: true}
which indicates a stream is done. This resulted in subscriptions stalling when they aren't cancelled externally with abreak
in afor-await-of
loop even though their underlying connection got closed properly. I opted for not using piping for transforming streams but rather inlining the byte parsing in thenext
method of the iterator.You can see more around the investigation of this problem in #1615 (comment).
Besides this, the PR also had a test that verified our code correctly handles keep-alive messages for long-running subscriptions which I added here as well.