feat: make requests extendable by adding requestMiddleware to provider options
#1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
Dhaiwat10
reviewed
Mar 1, 2024
Dhaiwat10
previously approved these changes
Mar 4, 2024
|
I would change the PR title to something that includes the word ' |
nedsalk
changed the title
requestMiddleware to provider options
danielbate
reviewed
Mar 4, 2024
Torres-ssf
reviewed
Mar 4, 2024
There was a problem hiding this comment.
I agree with @danielbate, we need some docs examples about this feature.
|
@danielbate @Torres-ssf Added docs in a1e6dc4 and 10d7176. |
danielbate
previously approved these changes
Mar 5, 2024
arboleya
requested changes
Mar 5, 2024
|
Coverage Report:
Changed Files:
|
arboleya
approved these changes
Mar 7, 2024
Torres-ssf
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
requestMiddlewarecallback as a way to modify the request object for every fetch call made towards the network. I didn't ponder about adding the capability for modifying the request object on a per-call basis because that'd be a bigger piece of work and we need at least this functionality for a bugfix on our apps related to sticky session cookies not being included. You can find more on that in the related issue.closes #1821