-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add try catch when parsing stream response #1839
chore: add try catch when parsing stream response #1839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we somehow provoke this error and have a test for this?
EDIT: This sort of thing (ccb706e) should ideally be done with a
RegExp
instead ofsplit/[n]
or other string manipulation workarounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. I requested changes for test simplification.
f1a8e54
to
4ee0b6f
Compare
Coverage Report:
Changed Files:
|
Adding this because of: ccb706e
The stream text data response was slightly modified on
fuel-core
0.23.0
resulting in an error being thrown without much context.With this, we can avoid lost time debugging it in the future if that happens again.
UPDATE:
The stream text data response did not change. The problem was another
data:
present on the text data, resulting in theString.split
not working as expected.