Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add native param types page #1870

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Conversation

sarahschwartz
Copy link
Member

This PR adds a new page in the Types section of the docs to explain some common contract input and output types for native Sway blockchain types.

@sarahschwartz sarahschwartz added the docs Requests pertinent to documentation label Mar 12, 2024
@sarahschwartz sarahschwartz self-assigned this Mar 12, 2024
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether the imports were intentional left out or not - so please disregard if so.

Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all - looks good 🥇

arboleya
arboleya previously approved these changes Mar 13, 2024
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits.

Great work @sarahschwartz!

Thank you. 🙌

apps/docs/src/guide/types/native-parameters.md Outdated Show resolved Hide resolved
apps/docs/src/guide/types/native-parameters.md Outdated Show resolved Hide resolved
apps/docs/src/guide/types/native-parameters.md Outdated Show resolved Hide resolved
apps/docs/src/guide/types/native-parameters.md Outdated Show resolved Hide resolved
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.49%(+0.02%) 70.35%(+0%) 78.03%(+0.05%) 79.58%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/program/src/revert/revert-error-codes.ts 15.38%
(+1.1%)
0%
(+0%)
0%
(+0%)
14.28%
(+0.95%)
🔴 packages/program/src/revert/revert-error.ts 11.11%
(+0.4%)
0%
(+0%)
0%
(+0%)
11.11%
(+0.4%)

@sarahschwartz sarahschwartz enabled auto-merge (squash) March 13, 2024 20:03
@sarahschwartz sarahschwartz merged commit 8cbd980 into master Mar 13, 2024
13 checks passed
@sarahschwartz sarahschwartz deleted the sarah/converting-types branch March 13, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants