Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrate wallet code snippets to doc-snippets #1885

Merged
merged 26 commits into from
Apr 22, 2024

Conversation

petertonysmith94
Copy link
Contributor

Relates: #1505

  • Move the wallet based tests for documentation to docs-snippets.

@petertonysmith94 petertonysmith94 self-assigned this Mar 18, 2024
@petertonysmith94 petertonysmith94 changed the title docs: migrate wallet docs from fuel gauge docs: migrate wallet code snippets to doc-snippets Apr 3, 2024
@Torres-ssf Torres-ssf removed their assignment Apr 18, 2024
@petertonysmith94 petertonysmith94 marked this pull request as ready for review April 19, 2024 05:57
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As no code has been removed from fuel-gauge, does this mean the snippets are still present there? I think we should clean those up for completeness.

arboleya
arboleya previously approved these changes Apr 19, 2024
@petertonysmith94
Copy link
Contributor Author

As no code has been removed from fuel-gauge, does this mean the snippets are still present there? I think we should clean those up for completeness.

40ad078

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.3%(+0%) 69.27%(+0%) 77.31%(+0%) 79.45%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 414e7d7 into master Apr 22, 2024
17 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/docs/migrate-wallet-docs-from-fuel-guage branch April 22, 2024 09:28
maschad pushed a commit that referenced this pull request Apr 22, 2024
* docs: moved wallet based doc tests, from fuel-guage to doc snippets

* chore: removed dev script

* docs: added wallet doc test to doc snippets

* chore: linting

* chore: removed redundant test file

* chore: update changeset

* chore: removed querying-the-chain (already in providers)

* chore: removed old doc-snippet

* chore: linting

* chore: fixing tests for wallet docs snippets

* chore: lint

* chore: removed doc snippet comments

---------

Co-authored-by: Sérgio Torres <30977845+Torres-ssf@users.noreply.github.com>
maschad pushed a commit that referenced this pull request Apr 22, 2024
* docs: moved wallet based doc tests, from fuel-guage to doc snippets

* chore: removed dev script

* docs: added wallet doc test to doc snippets

* chore: linting

* chore: removed redundant test file

* chore: update changeset

* chore: removed querying-the-chain (already in providers)

* chore: removed old doc-snippet

* chore: linting

* chore: fixing tests for wallet docs snippets

* chore: lint

* chore: removed doc snippet comments

---------

Co-authored-by: Sérgio Torres <30977845+Torres-ssf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants