Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: handling EADDRNOTAVAIL errors on top of ECONNREFUSED #1967

Merged
merged 2 commits into from
Mar 28, 2024
Merged

chore: handling EADDRNOTAVAIL errors on top of ECONNREFUSED #1967

merged 2 commits into from
Mar 28, 2024

Conversation

arboleya
Copy link
Member

This was failing locally for those not using Linux (hence why it works in CI).

image

I tracked it down to this cause.

@arboleya arboleya added the chore Issue is a chore label Mar 28, 2024
@arboleya arboleya self-assigned this Mar 28, 2024
@arboleya arboleya enabled auto-merge (squash) March 28, 2024 16:49
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
81.22%(+0%) 71.56%(-0.02%) 78.77%(+0%) 81.32%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/fuels/src/cli/commands/deploy/createWallet.ts 91.66%
(+0%)		 75%
(-8.33%)		 100%
(+0%)		 91.66%
(+0%)

@arboleya arboleya merged commit fb941a9 into master Mar 28, 2024
15 checks passed
@arboleya arboleya deleted the aa/chore/adjusting-error-handling branch March 28, 2024 16:57
@fuel-service-user fuel-service-user mentioned this pull request Mar 28, 2024
Merged
@nedsalk nedsalk mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@arboleya arboleya

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arboleya @danielbate @Torres-ssf