Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant error codes #2002

Merged
merged 17 commits into from
Apr 4, 2024
Merged

chore: remove redundant error codes #2002

merged 17 commits into from
Apr 4, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Apr 2, 2024 •
edited
Loading

Related to #1556

  • Removed redundant error codes.

@petertonysmith94 petertonysmith94 mentioned this pull request Apr 2, 2024
Closed
9 tasks
@petertonysmith94 petertonysmith94 self-assigned this Apr 2, 2024
@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Apr 2, 2024
@petertonysmith94 petertonysmith94 marked this pull request as ready for review April 2, 2024 16:05
Torres-ssf
Torres-ssf previously approved these changes Apr 3, 2024
View reviewed changes
danielbate
danielbate requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thought about hexlify usage, rest looks good

packages/contract/src/contract-factory.ts Show resolved Hide resolved
packages/contract/src/util.ts Show resolved Hide resolved
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) April 3, 2024 14:14
danielbate
danielbate previously approved these changes Apr 3, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Coverage Report:

Lines Branches Functions Statements
81.29%(+0.07%) 71.74%(+0.18%) 78.77%(+0%) 81.39%(+0.07%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/Interface.ts 79.16%
(+7.74%)		 66.66%
(+10.41%)		 81.25%
(+0%)		 76.92%
(+6.92%)

@petertonysmith94 petertonysmith94 merged commit 0be814e into master Apr 4, 2024
15 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/remove-redundant-error-codes branch April 4, 2024 06:18
@fuel-service-user fuel-service-user mentioned this pull request Apr 4, 2024
Merged
@nedsalk nedsalk mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petertonysmith94 @danielbate @Torres-ssf @Dhaiwat10