New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hide unnecessary logs and add loading spinners for create-fuels
#2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
April 4, 2024 12:58
This PR is published in NPM with version 0.0.0-pr-2011-20240404132212 |
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
danielbate
approved these changes
Apr 4, 2024
petertonysmith94
approved these changes
Apr 4, 2024
Coverage Report:
Changed Files:
|
@Dhaiwat10 I couldn't help but notice how you ran the tool in the video:
Is this still a thing, or why did you demo it like this? |
@arboleya that is because I am using the locally built binaries to run the CLI for the demo, without releasing it anywhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR hides unnecessary logs from the 'install dependencies' step for the
create-fuels
CLI, and adds some nice loading spinners for the two steps that we have.Users can opt into verbose logging via the
--verbose
flag.Recording.2024-04-04.182645.mp4
Closes #2006