Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide unnecessary logs and add loading spinners for create-fuels #2011

Merged
merged 11 commits into from Apr 4, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Apr 4, 2024

Summary

This PR hides unnecessary logs from the 'install dependencies' step for the create-fuels CLI, and adds some nice loading spinners for the two steps that we have.

Users can opt into verbose logging via the --verbose flag.

Recording.2024-04-04.182645.mp4

Closes #2006

Copy link
Contributor

github-actions bot commented Apr 4, 2024

This PR is published in NPM with version 0.0.0-pr-2011-20240404132212

Dhaiwat10 and others added 3 commits April 4, 2024 18:41
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Coverage Report:

Lines Branches Functions Statements
81.05%(+0.01%) 71.6%(-0.04%) 79.09%(+0%) 81.13%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 86.9%
(+0.83%)
65.85%
(-1.71%)
83.33%
(+0%)
87.35%
(+0.77%)

@Dhaiwat10 Dhaiwat10 merged commit 0cda64a into master Apr 4, 2024
15 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-logging-and-looks branch April 4, 2024 18:38
@arboleya
Copy link
Member

arboleya commented Apr 6, 2024

@Dhaiwat10 I couldn't help but notice how you ran the tool in the video:

node packages/create-fuels/dist/bin.global.js

Is this still a thing, or why did you demo it like this?

@Dhaiwat10
Copy link
Member Author

@arboleya that is because I am using the locally built binaries to run the CLI for the demo, without releasing it anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm create fuels logs out too many things during installation
4 participants