Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed predicateDataBytes from the Predicate class #2025

Merged
merged 8 commits into from
Apr 10, 2024
Merged

chore: removed predicateDataBytes from the Predicate class #2025

merged 8 commits into from
Apr 10, 2024

Conversation

petertonysmith94
Copy link
Contributor

Closes #1863

  • Removed the predicateDataBytes from the Predicate class.

@petertonysmith94 petertonysmith94 changed the title Ps/chore/remove unused variable from predicate chore: removed predicateDataBytes from the Predicate class Apr 8, 2024
@arboleya arboleya added the bug Issue is a bug label Apr 9, 2024
@petertonysmith94 petertonysmith94 marked this pull request as ready for review April 10, 2024 12:20
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.41%(+0%) 69.7%(+0.03%) 77.47%(+0.02%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/utilities.ts 98.24%
(+0.03%)		 90%
(+0%)		 100%
(+0%)		 98.36%
(+0.06%)
🔴 packages/account/src/predicate/predicate.ts 30%
(-1.37%)		 35.71%
(+0%)		 20%
(+0%)		 30%
(-1.37%)

@petertonysmith94 petertonysmith94 merged commit 155b6f2 into master Apr 10, 2024
15 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/remove-unused-variable-from-predicate branch April 10, 2024 13:21
@fuel-service-user fuel-service-user mentioned this pull request Apr 10, 2024
Merged
@nedsalk nedsalk mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate a potentially unset property on the Predicate class
4 participants
@petertonysmith94 @danielbate @Dhaiwat10 @arboleya