chore: add initial depcheck using knip
#2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
changed the title
depcheck using knip
maschad
commented
Apr 10, 2024
maschad
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
petertonysmith94
as code owners
danielbate
reviewed
Apr 10, 2024
maschad
changed the title
depcheck using knip depcheck using knip
petertonysmith94
previously approved these changes
Apr 10, 2024
arboleya
reviewed
Apr 15, 2024
Torres-ssf
approved these changes
Apr 16, 2024
arboleya
approved these changes
Apr 16, 2024
petertonysmith94
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2024
I decided to go with knip as it has better support for monorepos and workspaces. It also supports finding unused files and exports as well, but I think that should be in a follow up issue as that would be a lot more sizeable.