Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow empty changesets for PRs that don't affect a package #2039

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Apr 11, 2024

The changeset package sometimes mandates an (empty) changeset even though no changes happened (e.g. when a test file is updated). This PR allows for the changeset linting to pass when a PR's changeset doesn't affect any package because that PR won't be referenced in the changelog anyways.

@nedsalk nedsalk enabled auto-merge (squash) April 11, 2024 11:06
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 69.7%(+0%) 77.33%(+0%) 79.52%(+0%)
Changed Files:

Coverage values did not change👌.

@nedsalk nedsalk merged commit 6de8fcb into master Apr 11, 2024
15 checks passed
@nedsalk nedsalk deleted the ns/chore/ignore-empty-changesets-in-linting branch April 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants