Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enabling v1 encoding for everything #2050

Merged
merged 139 commits into from Apr 25, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Apr 12, 2024

Closes #2043
Closes #2132
Closes #1880

This PR:

  • Adds the --experimental-new-encoding build flag to all forc workspaces
  • Fixes the contract call script to use the correct gas offset
  • Disables setting the heap type registers for v1
  • Disables multicall validation for v1
  • Enables previously skipped heap tests (including heap in multicall)
  • Enables nested heap support
  • Removes documentation around workaround for revert errors (they now work as expected as we can extract str slice from logs in v1)

Dhaiwat10
Dhaiwat10 previously approved these changes Apr 25, 2024
nedsalk
nedsalk previously approved these changes Apr 25, 2024
Base automatically changed from aa/chore/upgrading-forc-0.53.0 to master April 25, 2024 17:35
@arboleya arboleya dismissed stale reviews from nedsalk, Dhaiwat10, petertonysmith94, maschad, Torres-ssf, and themself April 25, 2024 17:35

The base branch was changed.

…/chore/experimental-forc-in-all-projects
@fuel-service-user
Copy link
Contributor

✨ A PR has been created under the rc-2050 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1249

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.87%(+0.53%) 70%(+0.7%) 77.5%(+0.12%) 80.01%(+0.52%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/FunctionFragment.ts 69.56%
(-1.45%)
69.69%
(+0%)
73.33%
(+0%)
69.44%
(-1.39%)
🔴 packages/abi-coder/src/encoding/coders/v0/BooleanCoder.ts 90.9%
(-9.1%)
89.47%
(-10.53%)
100%
(+0%)
90.9%
(-9.1%)
🔴 packages/abi-coder/src/encoding/coders/v0/EnumCoder.ts 81.81%
(-18.19%)
75%
(-25%)
100%
(+0%)
81.81%
(-18.19%)
🔴 packages/abi-coder/src/encoding/coders/v0/NumberCoder.ts 97.14%
(-2.86%)
95.65%
(-4.35%)
100%
(+0%)
97.14%
(-2.86%)
🔴 packages/abi-coder/src/encoding/coders/v0/OptionCoder.ts 0%
(-91.66%)
0%
(-87.5%)
0%
(-100%)
0%
(-91.66%)
packages/abi-coder/src/encoding/coders/v1/EnumCoder.ts 100%
(+21.96%)
100%
(+31.25%)
100%
(+0%)
100%
(+21.96%)
packages/abi-coder/src/encoding/coders/v1/OptionCoder.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)
packages/abi-coder/src/encoding/coders/v1/StructCoder.ts 100%
(+5%)
100%
(+16.67%)
100%
(+0%)
100%
(+5%)
🔴 packages/abi-coder/src/encoding/strategies/getCoderV1.ts 91.66%
(+89.58%)
86.66%
(+86.66%)
100%
(+100%)
91.66%
(+89.58%)
🔴 packages/abi-coder/src/utils/utilities.ts 96.49%
(-1.75%)
80%
(-10%)
100%
(+0%)
96.72%
(-1.64%)
🔴 packages/program/src/contract-call-script.ts 10.83%
(-0.18%)
0%
(+0%)
0%
(+0%)
10.56%
(-0.18%)

@danielbate danielbate merged commit 3d2e5c4 into master Apr 25, 2024
17 checks passed
@danielbate danielbate deleted the db/chore/experimental-forc-in-all-projects branch April 25, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants