Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: properly load env vars in create-fuels template, and add docs for fuels CLI #2051

Merged
merged 6 commits into from Apr 15, 2024
Merged

feat: properly load env vars in create-fuels template, and add docs for fuels CLI #2051

merged 6 commits into from Apr 15, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Apr 14, 2024 •
edited

Summary

This PR introduces these changes:

  1. The fuels.config.ts file provided by the create-fuels template now makes use of dotenv to properly load environment variables from .env files.
  2. There is new added documentation around how to read environment variables in a fuels.config.ts file.

Closes #2036

@Dhaiwat10 Dhaiwat10 added the bug label Apr 14, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Apr 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 14, 2024 •
edited

This PR is published in NPM with version 0.0.0-pr-2051-20240414141631

@Dhaiwat10 Dhaiwat10 changed the title fix: add the ability to read process.env variables in the fuels.config.ts file fix: properly load env vars in create-fuels template, and add docs for fuels CLI Apr 14, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review April 14, 2024 14:19
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) April 14, 2024 14:19
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.38%(-0.01%) 69.67%(-0.06%) 77.33%(+0%) 79.53%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/fuels.config.ts 0%
(+0%)		 0%
(+0%)		 100%
(+100%)		 0%
(+0%)

@Dhaiwat10 Dhaiwat10 merged commit 40622a5 into master Apr 15, 2024
15 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/fix-fuels-config-env-load branch April 15, 2024 08:45
@fuel-service-user fuel-service-user mentioned this pull request Apr 15, 2024
Merged
@Dhaiwat10 Dhaiwat10 changed the title fix: properly load env vars in create-fuels template, and add docs for fuels CLI feat: properly load env vars in create-fuels template, and add docs for fuels CLI Apr 15, 2024
@nedsalk nedsalk mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The fuels.config.ts file cannot read process.env variables
3 participants
@Dhaiwat10 @danielbate @petertonysmith94