feat: exclusive enum type inference in typegen #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
arboleya
reviewed
Apr 23, 2024
There was a problem hiding this comment.
How come this PR is closing #1891?
AFAIU, the API will still be:
await contract.functions.new_game({ Address: { value: walletAddress });
await contract.functions.new_game({ ContractId: { value: contractId });Instead of:
await contract.functions.new_game({ address: walletAddress });
await contract.functions.new_game({ contractId: contractId });
|
@arboleya Oof, good catch. Converting to draft. Got a bit elated with the new generic behavior and forgot about that 😅 |
|
@arboleya Actually, we can treat this PR as a pre-step that can be merged as-is because it touches upon all enums, not just |
arboleya
previously approved these changes
Apr 23, 2024
petertonysmith94
previously approved these changes
Apr 23, 2024
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
arboleya
approved these changes
Apr 23, 2024
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
Torres-ssf
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better type inference for all typegen enums. Now, if you provide one property of an enum, you can't provide the other ones. Here's the change in a nutshell: playground.
This PR is a step towards resolving #1891, but I set it as a separate PR because it touches upon enum type inference generally, not just the
Identityenum. As @danielbate alluded to here, there's no reason to not apply the same type inference for all enums.