Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert update deps #2157

Merged
merged 2 commits into from
Apr 24, 2024
Merged

chore: revert update deps #2157

merged 2 commits into from
Apr 24, 2024

Conversation

petertonysmith94
Copy link
Contributor

Reverts #2155

@petertonysmith94 petertonysmith94 changed the title Revert "build: update deps" chore: revert update deps Apr 24, 2024
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) April 24, 2024 15:46
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.34%(+0%) 69.3%(+0%) 77.38%(+0%) 79.49%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 9fc63db into master Apr 24, 2024
17 checks passed
@petertonysmith94 petertonysmith94 deleted the revert-2155-build/upgrade-deps branch April 24, 2024 16:00
maschad
maschad reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this should have been reverted.

I think we should have rerun the tests a few times to ensure that the additional flakiness was gone before merging since the impetus behind the revert was due to failures on a separate branch

I am running the browser tests albeit locally on the upgrade deps branch and they are passing consistently.

@maschad maschad mentioned this pull request Apr 24, 2024
Merged
danielbate pushed a commit that referenced this pull request Apr 25, 2024
@petertonysmith94 @danielbate
chore: revert update deps (#2157)
cf5e2ce 
* Revert "build: update deps (#2155)"

This reverts commit 3299256.

* Changeset
@Dhaiwat10 Dhaiwat10 mentioned this pull request Apr 25, 2024
Closed
@petertonysmith94 petertonysmith94 self-assigned this Apr 29, 2024
@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad left review comments

@danielbate danielbate danielbate approved these changes

@nedsalk nedsalk nedsalk approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petertonysmith94 @danielbate @maschad @nedsalk @Torres-ssf