Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not run release workflow when branch is created #2216

Merged
merged 6 commits into from
May 10, 2024
Merged

fix: do not run release workflow when branch is created #2216

merged 6 commits into from
May 10, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Apr 30, 2024

I tested this logic:

  1. By pushing bad803e to this already-existing branch (action), which ran the "Branch already exists" step
  2. I then deleted the branch from github
  3. I created the branch again with the same commit, which triggered the action again, but now it ran the "Branch newly created" step

closes #2215

@nedsalk nedsalk added the bug Issue is a bug label Apr 30, 2024
@nedsalk nedsalk self-assigned this Apr 30, 2024
arboleya
arboleya approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch! 👏

.github/workflows/release.yaml Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.75%(+0%) 69.42%(+0%) 77.83%(+0%) 79.87%(+0%)
Changed Files:

Coverage values did not change👌.

@nedsalk nedsalk enabled auto-merge (squash) May 10, 2024 12:59
@nedsalk nedsalk merged commit c4307bd into master May 10, 2024
18 of 19 checks passed
@nedsalk nedsalk deleted the ns/fix/no-release-run-on-branch-creation branch May 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not run Release action on release/* branch creation
6 participants
@nedsalk @arboleya @danielbate @petertonysmith94 @Torres-ssf @Dhaiwat10