Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid overriding user gasLimit and maxFee inputs #2262

Merged
merged 25 commits into from May 10, 2024
Merged

fix: avoid overriding user gasLimit and maxFee inputs #2262

merged 25 commits into from May 10, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf added the bug label May 8, 2024
@Torres-ssf Torres-ssf self-assigned this May 8, 2024
@Torres-ssf Torres-ssf changed the title fix: avoid overriding user gasLimit and maxFee inputs fix: avoid overriding user gasLimit and maxFee inputs May 8, 2024
@Torres-ssf Torres-ssf requested a review from nedsalk May 8, 2024 12:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited

This PR is published in NPM with version 0.0.0-pr-2262-20240508162249

arboleya
arboleya reviewed May 8, 2024
View reviewed changes
.github/workflows/pr-release.yaml Outdated Show resolved Hide resolved
packages/account/src/account.ts Outdated Show resolved Hide resolved
packages/account/src/account.ts Outdated Show resolved Hide resolved
@Torres-ssf Torres-ssf requested a review from arboleya May 8, 2024 15:15
nedsalk
nedsalk previously approved these changes May 8, 2024
View reviewed changes
@Torres-ssf Torres-ssf enabled auto-merge (squash) May 8, 2024 19:06
Dhaiwat10
Dhaiwat10 previously approved these changes May 8, 2024
View reviewed changes
danielbate
danielbate previously approved these changes May 9, 2024
View reviewed changes
@Torres-ssf
Copy link
Contributor Author

Torres-ssf commented May 9, 2024 •
edited

Should we add a test to ensure that the maxFee passed in is the one that's respected?

@maschad f8bed39

maschad
maschad approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, but otherwise nice work! 🚀

packages/account/src/account.test.ts Show resolved Hide resolved
packages/account/src/account.test.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.8%(+0.05%) 69.63%(+0.21%) 77.83%(+0%) 79.91%(+0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 83%
(+1.13%)		 66.66%
(+2.15%)		 76%
(+0%)		 82.58%
(+1.13%)

petertonysmith94
petertonysmith94 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🍏 Small comment.

packages/account/src/account.ts Show resolved Hide resolved
@Torres-ssf Torres-ssf merged commit 9bc893b into master May 10, 2024
19 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/avoid-overriding-user-gaslimit-maxfee branch May 10, 2024 12:51
@fuel-service-user fuel-service-user mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 left review comments

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contract call not considering txParams Consider not overriding user-specified gasLimit
7 participants
@Torres-ssf @arboleya @danielbate @maschad @petertonysmith94 @nedsalk @Dhaiwat10