Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added CDN path for icon assets #2279

Merged
merged 11 commits into from May 10, 2024

Conversation

petertonysmith94
Copy link
Contributor

Closes #1893

Copy link
Contributor

github-actions bot commented May 9, 2024

This PR is published in NPM with version 0.0.0-pr-2279-20240509170857

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@petertonysmith94 petertonysmith94 merged commit 1115ade into master May 10, 2024
21 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/add-img-url-for-assets branch May 10, 2024 05:25
type: 'fuel',
chainId: CHAIN_IDS.fuel.devnet,
decimals: 9,
assetId: '0x0000000000000000000000000000000000000000000000000000000000000000',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our BaseAssetId is dynamic now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iconPaths for assets not being resolved on build
4 participants