feat: VecCoder@v1 accepts UInt8Array as encode input
#2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
nedsalk,
petertonysmith94 and
maschad
as code owners
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
nedsalk
approved these changes
May 12, 2024
petertonysmith94
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work in #2018 made a
UInt8Arraya valid input for forVecCoder.encode. This is useful for working with bytecode, where the function likely accepts aVec<u8>and the input would be passed as arrayified binary, so requiring anumber[]is poor DX.This feature was not brought across to
V1, it was probably missed due to the timing overlap. This PR introduces that change toV1encoding.