Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate status from estimation dry-run #2291

Merged
merged 21 commits into from
May 17, 2024
Merged

fix: validate status from estimation dry-run #2291

merged 21 commits into from
May 17, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented May 13, 2024 •
edited

@Torres-ssf Torres-ssf added the bug label May 13, 2024
@Torres-ssf Torres-ssf self-assigned this May 13, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review May 16, 2024 01:56
petertonysmith94
petertonysmith94 reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ❤️

packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
maschad
maschad approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Torres-ssf Torres-ssf enabled auto-merge (squash) May 17, 2024 11:24
@Torres-ssf Torres-ssf disabled auto-merge May 17, 2024 11:52
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.78%(-0.06%) 70.73%(+0.02%) 76.82%(-0.05%) 79.86%(-0.06%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 67.12%
(-1.04%)		 55.82%
(-0.15%)		 76.19%
(-0.91%)		 67.37%
(-1.02%)
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 71.69%
(+0.54%)		 50%
(+0%)		 87.5%
(+0%)		 71.69%
(+0.54%)
🔴 packages/account/src/providers/utils/extract-tx-error.ts 10%
(+0.25%)		 0%
(+0%)		 0%
(+0%)		 9.09%
(+0.21%)
🔴 packages/program/src/script-request.ts 4.54%
(-0.11%)		 0%
(+0%)		 0%
(+0%)		 4.54%
(-0.11%)

@Torres-ssf Torres-ssf merged commit d5116ce into master May 17, 2024
19 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/validate-receipts-from-estimation-dry-run branch May 17, 2024 12:09
@fuel-service-user fuel-service-user mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Dry-Run Gas Estimation Error Handling
5 participants
@Torres-ssf @arboleya @maschad @petertonysmith94 @danielbate