-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: transfer for multiple addresses #2333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job on this 🚀 - just left one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great feature and adds a lot of value. My only questions is around the spec in #161.
Also this should be integrated to enable queue txs instead of single tx
I can see we are using a single tx here, should we be queueing?
✨ A PR has been created under the |
@danielbate I reckon you were mentioning something like this: a56d59b, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
But this still uses a single tx? A single transaction request with multiple recipient outputs. Whereas this issue also asks for:
|
@danielbate Thanks for your explanation. I see your point. I've created a specific issue for this since it's a completely different thing from multiple addresses transferring. |
Coverage Report:
Changed Files:
|
Breaking Changes:
BaseInvocationScope.addTransfer
parameters