-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add test to verify create fuels
template integrity
#2364
chore: add test to verify create fuels
template integrity
#2364
Conversation
…/chore/add-automated-test-suite-for-create-fuels
This PR is published in NPM with version 0.0.0-pr-2364-20240522151632 |
create fuels
CLIe2e
test for create fuels
CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments:
-
I think the title of this PR should be
chore: add test to verify create-fuels template
-
given that this PR doesn't necessarily add any functionality that we would use without chore: add integration test for the
create fuels
template #2278 I think it should be based off thedp/create-fuels-template-e2e-tests
branch -
When running this locally the tests don't seem to pass for me.
![Screenshot 2024-05-23 at 11 52 05 AM](https://private-user-images.githubusercontent.com/9755286/333275049-a27ef881-e1eb-4f3e-b148-1d1a5df05788.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NjEwMTYsIm5iZiI6MTcyMTc2MDcxNiwicGF0aCI6Ii85NzU1Mjg2LzMzMzI3NTA0OS1hMjdlZjg4MS1lMWViLTRmM2UtYjE0OC0xZDFhNWRmMDU3ODgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjNUMTg1MTU2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzcxYTBlNmIxMDJkZWE0ODQzOWNmODgzNmEzY2YyMzQ5YjVhYWE5MTdiMzI3ZWY1NGQ1NzQ4ODA1YThlZTM4ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.o_l9nO3Jd61B_WEp0_8JiURq-Gjm5uwt-4R_Adzok_s)
e2e
test for create fuels
CLIcreate fuels
template integrity
|
Maybe I'm missing something but I am not sure what the use case for this test is outside of #2278 |
#2278 is adding UI testing for our template, against a local node. #2364 is adding tests around performing #2170 will be adding a test that performs I think it would be more productive to have a call with @Dhaiwat10 and myself over this is you are still unsure. |
Coverage Report:
Changed Files:Coverage values did not change👌. |
Closes #2265